[bug] Don't skip column options.#3089
Merged
Majkl578 merged 1 commit intodoctrine:masterfrom Apr 6, 2018
and1truong:dont-skip-column-options
Merged
[bug] Don't skip column options.#3089Majkl578 merged 1 commit intodoctrine:masterfrom and1truong:dont-skip-column-options
Majkl578 merged 1 commit intodoctrine:masterfrom
and1truong:dont-skip-column-options
Conversation
Contributor
Author
|
Very unstable Travis ); |
Contributor
Author
|
@Majkl578 can you review? |
Majkl578
reviewed
Apr 6, 2018
lib/Doctrine/DBAL/Schema/Column.php
Outdated
| $method = "set".$name; | ||
| if ( ! method_exists($this, $method)) { | ||
| // next major: throw an exception | ||
| // next major: throw an exception. |
Contributor
There was a problem hiding this comment.
This change seems unrelated.
| * @group legacy | ||
| * @expectedDeprecation The "unknown_option" column option is not supported, setting it is deprecated and will cause an error in Doctrine 3.0 | ||
| */ | ||
| public function testOptionsShouldNotBeIgnored() |
Contributor
There was a problem hiding this comment.
Can you please add void return type?
| public function testOptionsShouldNotBeIgnored() | ||
| { | ||
| $col1 = new Column('bar', Type::getType(Type::INTEGER), ['unknown_option' => 'bar', 'notnull' => true]); | ||
| $this->assertTrue($col1->getNotnull()); |
Contributor
There was a problem hiding this comment.
We use static assertion calls using self::.
Contributor
Author
|
All fixed per your suggestion. Thanks for fast response @Majkl578. |
greg0ire
approved these changes
Apr 6, 2018
Member
greg0ire
left a comment
There was a problem hiding this comment.
Oh right, looks like I forgot this was in a foreach, sorry for this :(
morozov
approved these changes
Apr 6, 2018
Majkl578
approved these changes
Apr 6, 2018
Contributor
|
@andytruong Thanks! |
Majkl578
added a commit
to Majkl578/doctrine-dbal
that referenced
this pull request
Apr 6, 2018
Backporting doctrine#3089 into 2.7
Contributor
|
Backported into 2.7 @ 2f64799 |
rgrellmann
pushed a commit
to Rossmann-IT/dbal
that referenced
this pull request
Apr 13, 2018
This release fixes unintentional BC breaks: 1. It was impossible to use deprecated fetch modes with PDO-based drivers. 2. An unsupported option passed to the `Column` object prevented subsequent options from being applied. 3. Date interval values stored prior to upgrade to `v2.7.0` were reported as invalid. Total issues resolved: **10** **Backwards Compatibility Fixes:** - [3082: Custom PDO fetch modes and 2.7.0](doctrine#3082) thanks to @corphi - [3088: Fix doctrine#3082: Add BC for PDO-only fetch modes](doctrine#3088) thanks to @corphi - [3089: Don't skip column options.](doctrine#3089) thanks to @andytruong - [3093: When updating to version v2.7 type DateInterval throws errors](doctrine#3093) thanks to @fnagel - [3097: Fix compatibility for pre-2.7 DateIntervalType format](doctrine#3097) thanks to @Majkl578 **Documentation Improvements:** - [3083: Document the correct way of configuring a MariaDB database with serverVersion](doctrine#3083) thanks to @tristanbes - [3084: README: Add 2.7, drop 2.5](doctrine#3084) thanks to @Majkl578 **Continuous Integration Improvements:** - [3085: Tests: remove implicit verbose flag](doctrine#3085) thanks to @Majkl578 - [3090: Add symfony tests listener](doctrine#3090) thanks to @greg0ire - [3095: CI: Add missing listener for MariaDB @ mysqli](doctrine#3095) thanks to @Majkl578 # gpg: directory `/n/.gnupg' created # gpg: new configuration file `/n/.gnupg/gpg.conf' created # gpg: WARNING: options in `/n/.gnupg/gpg.conf' are not yet active during this run # gpg: DBG: locking for `/n/.gnupg/pubring.gpg.lock' done via O_EXCL # gpg: keyring `/n/.gnupg/pubring.gpg' created # gpg: Signature made Sun Apr 8 07:24:49 2018 using RSA key ID 543AE995 # gpg: Can't check signature: public key not found # Conflicts: # .gitignore # lib/Doctrine/DBAL/Driver/OCI8/Driver.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.