Allow dynamic intervals in DATE_ADD & DATE_SUB for SQLite#3019
Allow dynamic intervals in DATE_ADD & DATE_SUB for SQLite#3019morozov merged 2 commits intodoctrine:masterfrom fogs:date_add
Conversation
|
Hi @Ocramius, This is the replacement for #2984 now including some unit tests. Let me know if that works for you or if you are missing something else. The Scrutinizer came back with "Tests: passed" but is complaining about "Failure condition met". Is that something I need to fix and if so, how? Our project is using doctrine/dbal in an older version. Will my patch be backported or can I do something to get it there? Would love to get rid of using my fork of doctrine in our project's composer.json. Thanks! |
|
Heya! Please do ignore the Scrutinizer-CI failure here :-) As for the backport: no, this is an addition, and it will land in DBAL 2.7 |
| } | ||
|
|
||
| if (! is_numeric($interval)) { | ||
| $interval = "' || " . $interval . " || '"; |
There was a problem hiding this comment.
The semantics depending on the value is a bit fishy. Do other platforms support something similar?
|
Someone needs to approve this before it gets into |
Fixing #2983
Replacing #2984