Allow dynamic intervals in DATE_ADD for SQLite#2984
Allow dynamic intervals in DATE_ADD for SQLite#2984fogs wants to merge 1 commit intodoctrine:masterfrom fogs:master
Conversation
|
Can you give an example of additional tests required? I did not find tests for DATE_ADD at all. |
|
#2482 includes similar changes |
|
@Ocramius, Thanks! |
|
It doesn't matter if it's a big or small project: if an addition or change isn't backed by tests, it should not land in the codebase. This should be something that applies also for your own projects ;-) As I've linked above, #2482 has similar tests - see https://github.com/vhraban/dbal/blob/d81e2a4e5937e045df4d79c8cad073d306c4abd6/tests/Doctrine/Tests/DBAL/Platforms/SqlitePlatformTest.php |
|
Closing in favor of #3019 which comes with the requested tests |
Fixing #2983