Autoload test and add preConnect Event on DBAL connect#27
Closed
Garfield-fr wants to merge 2 commits intodoctrine:masterfrom
Garfield-fr:master
Closed
Autoload test and add preConnect Event on DBAL connect#27Garfield-fr wants to merge 2 commits intodoctrine:masterfrom Garfield-fr:master
Garfield-fr wants to merge 2 commits intodoctrine:masterfrom
Garfield-fr:master
Conversation
Member
|
You should instead convert the testsuite to use an XML configuration file, like it is done in the Common repo: doctrine/common@d2241e9 |
Member
|
What is the use-case for this? |
Member
|
I don't see the use case here and don't want to add so many events to the core, as it confuses developers to pick from them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.