This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Add userns to run flags #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
af2133c to
4e6e252
Compare
Contributor
Author
|
@calavera can you please direct me to the appropriate reviewer for this change? |
Contributor
|
TBH, I'd rather not bring these types here if they're not used in both sides, client and server. This is very similar to #56. |
Contributor
Author
|
@calavera your comments is about |
Following the discussions in #20111, #19995 and #17409 we need a mechinshem to enable skipping userns flag when userns re-mapping was specified in the daemon level. As suggest by #mrunalp, a coherent and consistent options is to add the userns flag to the engine-api. Signed-off-by: Liron Levin <liron@twistlock.com>
4e6e252 to
cba974b
Compare
Contributor
Author
|
@calavera I've cleanup this change and removed all unrelated code. |
Contributor
Author
Contributor
|
LGTM - this is in support of the new flag to allow a privileged mode run when user namespaces are enabled. I believe it is used on both client and server as the flag parsing requires these functions. |
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussions in #20111, #19995 and #17409 we need a
mechinshem to enable skipping userns flag when userns re-mapping was
specified in the daemon level.
As suggest by #mrunalp, a coherent and consistent options is to add the
userns flag to the engine-api.
I've also moved the UT found at:
/docker/docker/runconfig/hostconfig_test.go next to hostconfig.go file
(since they test the specified functionality).