Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Add a specific config for the update command#11

Merged
calavera merged 1 commit intodocker-archive-public:masterfrom
vdemeester:docker-18957-update-config
Jan 7, 2016
Merged

Add a specific config for the update command#11
calavera merged 1 commit intodocker-archive-public:masterfrom
vdemeester:docker-18957-update-config

Conversation

@vdemeester
Copy link
Contributor

This is related to moby/moby#19104.

This is a proposal for #18957, to reduce what we send to the update endpoint. This also make it clear what is mutable in the container, and untie it from Config/HostConfig. It is still easy to add more attributes

This allows use to control more what is or is not mutable in a container and remove the use of the internal HostConfig struct to be used 🐳.

/cc @calavera @tiborvass

Signed-off-by: Vincent Demeester vincent@sbr.pm

This allows to define clearly what is mutable or not in a container.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@tiborvass
Copy link
Contributor

LGTM

1 similar comment
@calavera
Copy link
Contributor

calavera commented Jan 7, 2016

LGTM

calavera added a commit that referenced this pull request Jan 7, 2016
Add a specific config for the update command
@calavera calavera merged commit c45d769 into docker-archive-public:master Jan 7, 2016
@vdemeester vdemeester deleted the docker-18957-update-config branch January 7, 2016 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants