This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Do not generate/load AppArmor profiles#645
Merged
dqminh merged 1 commit intodocker-archive:masterfrom Jun 22, 2015
Merged
Conversation
Profiles for AppArmor should be specified by consuming applications. A one-size-fits all policy specific to Docker does not belong in libcontainer. This change eliminates loading of the policy from libcontainer. It also eliminates the check for the userland tools as these were only needed for libcontainer's policy loader. Applying profiles does not require the userland tools and some systems may, in fact, have functional AppArmor without having these tools on the host. Signed-off-by: Eric Windisch <eric@windisch.us>
4acc47f to
61f9c8d
Compare
Contributor
Author
|
Docker will need moby/moby#13144 before updating libcontainer if this is applied. |
Contributor
|
LGTM |
Contributor
|
LGTM. Delegating the generation of apparmor profile to the consumer looks good ! |
dqminh
added a commit
that referenced
this pull request
Jun 22, 2015
Do not generate/load AppArmor profiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiles for AppArmor should be specified by consuming
applications. A one-size-fits all policy specific to Docker
does not belong in libcontainer.
This change eliminates loading of the policy from libcontainer.
It also eliminates the check for the userland tools as these
were only needed for libcontainer's policy loader. Applying
profiles does not require the userland tools and some
systems may, in fact, have functional AppArmor without
having these tools on the host.
Signed-off-by: Eric Windisch eric@windisch.us