This repository was archived by the owner on Dec 13, 2018. It is now read-only.
user: fix function signatures#301
Merged
vmarmol merged 2 commits intodocker-archive:masterfrom Dec 16, 2014
cyphar:user-fix-names
Merged
user: fix function signatures#301vmarmol merged 2 commits intodocker-archive:masterfrom cyphar:user-fix-names
vmarmol merged 2 commits intodocker-archive:masterfrom
cyphar:user-fix-names
Conversation
This patch changes the incorrectly named functions GetPasswdFile, GetGroupFile, GetExecUserFile and several internal components to GetPasswdPath, GetGroupPath, etc -- as these are far more appropriate names and more clearly convey to users what the arguments represent. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> (github: cyphar)
This patch switches libcontainer's usage of the user/ API to the new version. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> (github: cyphar)
Contributor
Author
|
LGTM |
Contributor
|
LGTM |
Contributor
|
posthumous LGTM too 👍 |
ColinHuang
pushed a commit
to fcwu/docker
that referenced
this pull request
Jan 5, 2015
This commit contains changes for docker: * user.GetGroupFile to user.GetGroupPath docker-archive/libcontainer#301 * Add systemd support for OOM docker-archive/libcontainer#307 * Support for custom namespaces docker-archive/libcontainer#279, docker-archive/libcontainer#312 * Fixes moby#9699 docker-archive/libcontainer#308 Signed-off-by: Alexander Morozov <lk4d4@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @crosbymichael pointed out in this discussion, the functions in the
userpackage (specifically the lookup API) are not correctly named. This patchset fixes this.Specifically, the following function names were changed to make the API more intuitive:
GetGroupFile=>GetGroupPathGetPasswdFile=>GetPasswdPathGetExecUserFile=>GetExecUserPathSigned-off-by: Aleksa Sarai cyphar@cyphar.com (github: cyphar)