Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[18.09 backport] gitutils: add validation for ref (CVE-2019-13139)#183

Merged
thaJeztah merged 1 commit intodocker-archive:18.09from
thaJeztah:18.09_backport_gitutils
Mar 27, 2019
Merged

[18.09 backport] gitutils: add validation for ref (CVE-2019-13139)#183
thaJeztah merged 1 commit intodocker-archive:18.09from
thaJeztah:18.09_backport_gitutils

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

backport of moby#38944 for 18.09

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 723b107ca4fba14580a6cd971e63d8af2e7d2bbe)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
(cherry picked from commit a588898)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 18.09.4 milestone Mar 26, 2019
@thaJeztah thaJeztah requested a review from tonistiigi as a code owner March 26, 2019 22:35
@thaJeztah
Copy link
Copy Markdown
Member Author

@tonistiigi @andrewhsu ptal

Copy link
Copy Markdown

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 200b524 into docker-archive:18.09 Mar 27, 2019
@thaJeztah thaJeztah deleted the 18.09_backport_gitutils branch March 27, 2019 08:34
thaJeztah added a commit to thaJeztah/cli that referenced this pull request Mar 27, 2019
relevant changes;

- moby/moby#38006 / docker-archive/engine#114 client: use io.LimitedReader for reading HTTP error
- moby/moby#38634 / docker-archive/engine#167 pkg/archive:CopyTo(): fix for long dest filename
  - fixes docker/for-linux#484 for 18.09
- moby/moby#38944 / docker-archive/engine#183 gitutils: add validation for ref
- moby/moby#37780 / docker-archive/engine#55 pkg/progress: work around closing closed channel panic
  - addresses moby/moby#/37735 pkg/progress: panic due to race on shutdown

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Mar 27, 2019
relevant changes;

- moby/moby#38006 / docker-archive/engine#114 client: use io.LimitedReader for reading HTTP error
- moby/moby#38634 / docker-archive/engine#167 pkg/archive:CopyTo(): fix for long dest filename
  - fixes docker/for-linux#484 for 18.09
- moby/moby#38944 / docker-archive/engine#183 gitutils: add validation for ref
- moby/moby#37780 / docker-archive/engine#55 pkg/progress: work around closing closed channel panic
  - addresses moby/moby#/37735 pkg/progress: panic due to race on shutdown

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: 010c234a0d5a03d450ebec60be37dd9f279feeca
Component: cli
@thaJeztah thaJeztah changed the title [18.09 backport] gitutils: add validation for ref [18.09 backport] gitutils: add validation for ref (CVE-2019-13139) Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants