Merged
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c7234cc to
88fc5db
Compare
dvdksn
commented
Jan 5, 2024
hugo.yaml
Outdated
| title: Docker Docs | ||
| baseURL: https://docs.docker.com | ||
| refLinksErrorLevel: ERROR | ||
| refLinksErrorLevel: WARNING |
Contributor
Author
There was a problem hiding this comment.
This is a temporary change to make the site build until we can vendor the latest version of docker/cli which contains a fix
Member
|
Also related; |
d6c41f5 to
daa4db4
Compare
daa4db4 to
51a8f72
Compare
neersighted
approved these changes
Jan 11, 2024
Member
neersighted
left a comment
There was a problem hiding this comment.
Not a docs-reviewer and haven't reviewed the implementation, but the preview looks like an excellent across-the-board improvement to me. The nav is much more usable and the concerns regarding user confusion due to canonicalization of commands are mostly addressed by the parenthetical titles for well-known commands.
51a8f72 to
b941d32
Compare
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
b941d32 to
3855262
Compare
rumpl
approved these changes
Jan 19, 2024
sam-thibault
approved these changes
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)
docker buildreference buildx#2186