docs: update link to docker build reference#2186
Conversation
|
I marked as do not merge but actually it should be fine to merge. It depends on the moby 25 release, but that's not a blocker for merging edit: hmm on the other hand, merging would cause the docs validation CI failure to appear everywhere so maybe let's hold until moby 25 |
|
|
||
| flags.StringSliceVar(&options.extraHosts, "add-host", []string{}, `Add a custom host-to-IP mapping (format: "host:ip")`) | ||
| flags.SetAnnotation("add-host", annotation.ExternalURL, []string{"https://docs.docker.com/engine/reference/commandline/build/#add-host"}) | ||
| flags.SetAnnotation("add-host", annotation.ExternalURL, []string{"https://docs.docker.com/engine/reference/commandline/image_build/#add-host"}) |
There was a problem hiding this comment.
Oh I thought it would be image/build, not image_build?
There was a problem hiding this comment.
it will be. I am not moving all the pages yet. First step is to get rid of the duplicates (aliases) and only keep the canonical files.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
780b3e4 to
68c3ac4
Compare
|
@crazy-max rebased, this should be good to go |
|
@dvdksn Looks like there is an issue with docs workflow: https://github.com/docker/buildx/actions/runs/7585104346/job/20660277217?pr=2186#step:6:489 I guess it needs changes first from docs repo? |
|
Yes this is expected, chicken and egg problem. I am renaming the page, but this file contains a link to the old page url... |
Update link to the
docker buildCLI reference