Why not have a ws=Falseparameter in attach_socket instead? I don't think this warrants adding a new method.

If you can change this (and rebase the PR), I'd be more than happy to accept it.

I'd argue that it's worth adding a new method for the same reason that the HTTP and Websockets endpoints have different URLs: methods where the returned value can be one of two completely different types are a bit weird.

But I don't have strong feelings either way, so I'm happy to make that change (some time in the next day or two, probably).

Cool, thanks for the update! I'll try to merge it by the end of this week.

So it looks like websocket-client doesn't support python 3 yet. I'm putting six.PY3 guards where it's used to avoid breaking the tests, and we'll have to watch for support in a future version (looks like they're actively working on it)

Thanks again for the contribution :)

Whoops! Good call, forgot to test it on 3.

On Fri, Nov 8, 2013 at 1:13 PM, Joffrey F notifications@github.com wrote:

Thanks again for the contribution :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/62#issuecomment-28084568
.