Skip to content

Skip flaky tests#796

Closed
dgageot wants to merge 1 commit into
docker:mainfrom
dgageot:skip-flaky-tests
Closed

Skip flaky tests#796
dgageot wants to merge 1 commit into
docker:mainfrom
dgageot:skip-flaky-tests

Conversation

@dgageot

@dgageot dgageot commented Nov 14, 2025

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot requested a review from a team as a code owner November 14, 2025 18:05
@dgageot

dgageot commented Nov 14, 2025

Copy link
Copy Markdown
Member Author

Merged with #772

@dgageot dgageot closed this Nov 14, 2025
@dgageot dgageot deleted the skip-flaky-tests branch February 27, 2026 19:38
hamza-jeddad added a commit that referenced this pull request Jun 9, 2026
…e template

The custom-base-image eval template (Dockerfile.custom.template) never
copied the docker-agent binary nor set the /run.sh entrypoint wrapper, so
eval containers inherited the base image's ENTRYPOINT ["/docker-agent"].
The agent YAML path was then passed as a bare subcommand, failing every
custom-image eval with:

    Error: unknown command "/configs/<agent>.yaml" for "docker-agent"

Bring the custom template to parity with the default template by copying
the binary from docker/docker-agent:edge and wrapping it with the
/run.sh "docker-agent run --exec --yolo --json" entrypoint. Add a
regression test asserting parity between the two templates.

Fixes #796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant