Apply newly loaded envvars to "DockerCli" and "APIClient"#9817
Merged
ulyssessouza merged 1 commit intodocker:v2from Sep 8, 2022
Merged
Apply newly loaded envvars to "DockerCli" and "APIClient"#9817ulyssessouza merged 1 commit intodocker:v2from
ulyssessouza merged 1 commit intodocker:v2from
Conversation
ulyssessouza
commented
Sep 7, 2022
13f3138 to
7f6abfe
Compare
milas
approved these changes
Sep 7, 2022
Contributor
milas
left a comment
There was a problem hiding this comment.
LGTM
Though I do think we should look to getting a fix into docker/cli itself; never a good feeling to be working around our own projects 🙈
Re-evaluate DockerCli and APIClient after reading the environment file. I can contain DOCKER_HOST and/or DOCKER_CONTEXT so the DockerCli passed by docker/cli has to be re-evaluated. Also checks for DOCKER_CERT_PATH and DOCKER_TLS_VERIFY. Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
7f6abfe to
79af3cd
Compare
milas
added a commit
that referenced
this pull request
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Re-evaluate DockerCli and APIClient after reading the environment file. I can contain DOCKER_HOST and/or DOCKER_CONTEXT so the DockerCli passed by docker/cli has to be re-evaluated. Also checks for DOCKER_CERT_PATH and DOCKER_TLS_VERIFY.
Related issue
Resolves #9210
Note: This is a "retry" of #9745 that was reverted in #9792