up: do not stop dependency containers#9701
Merged
Conversation
This keeps parity with v1, where only the containers explicitly passed to `up` are torn down when `Ctrl-C` is hit, so any dependencies that got launched (or orphan containers hanging around) should not be touched. Fixes docker#9696. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
laurazard
approved these changes
Aug 1, 2022
Member
laurazard
left a comment
There was a problem hiding this comment.
LGTM! Also, RequireEventuallyContains and RequireServiceState are nice, maybe we can refactor some other tests 😅
laurentsimon
pushed a commit
to laurentsimon/compose
that referenced
this pull request
Aug 10, 2022
This keeps parity with v1, where only the containers explicitly passed to `up` are torn down when `Ctrl-C` is hit, so any dependencies that got launched (or orphan containers hanging around) should not be touched. Fixes docker#9696. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Only the services passed via
argsare removed at the endof a non-detached
upcommand invocation now.This keeps parity with v1, where only the containers explicitly
passed to
upare torn down whenCtrl-Cis hit, so anydependencies that got launched (or orphan containers hanging
around) should not be touched.
Related issue
Fixes #9696.
(not mandatory) A picture of a cute animal, if possible in relation with what you did
