attach _only_ to services declared by project applying profiles#9488
Merged
attach _only_ to services declared by project applying profiles#9488
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
glours
approved these changes
May 20, 2022
Contributor
glours
left a comment
There was a problem hiding this comment.
LGTM and works as expected with the issue sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
ensure we only attach to services defined by project with applied profiles
if we don't, we will attach to all containers created with project label, which might match disabled profiles
Related issue
close #9286
(not mandatory) A picture of a cute animal, if possible in relation with what you did