Skip to content

compose down exit=0 if nothing to remove#9440

Merged
glours merged 1 commit intodocker:v2from
ndeloof:down_error
May 6, 2022
Merged

compose down exit=0 if nothing to remove#9440
glours merged 1 commit intodocker:v2from
ndeloof:down_error

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 4, 2022

What I did
Exit with status=0 when nothing has been found to be removed
Just print a warning

Related issue
closes #9426

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@ndeloof ndeloof requested review from glours and ulyssessouza May 4, 2022 09:13
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when the CI will be fixed

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours merged commit 2f47e45 into docker:v2 May 6, 2022
@ndeloof ndeloof deleted the down_error branch December 20, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in down in 2.5.0 - exit code for "nothing needed" went from 0 (success) to 1 (failure)

3 participants