Takes COMPOSE_PROJECT_NAME into consideration on commands#9332
Merged
ulyssessouza merged 1 commit intodocker:v2from Mar 31, 2022
Merged
Takes COMPOSE_PROJECT_NAME into consideration on commands#9332ulyssessouza merged 1 commit intodocker:v2from
ulyssessouza merged 1 commit intodocker:v2from
Conversation
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
8a2ee11 to
eee0e8b
Compare
hotzevzl
added a commit
to Vizzuality/marxan-cloud
that referenced
this pull request
May 6, 2022
This being make, the original implementation caused the value of the make variable COMPOSE_PROJECT_NAME to _include the surrounding double-quotes_, and this _happened_ to work just because we were using this variable in shell commands, where the quoting would be handled as normal CLI quoting of a string. However, since we _also_ make this make variable available as environment variable (through the `export` command through which we set env vars from a dotenv file), this ended up breaking things from Compose v2.4 through this change: docker/compose#9332.
hotzevzl
added a commit
to Vizzuality/marxan-cloud
that referenced
this pull request
May 6, 2022
This being make, the original implementation caused the value of the make variable COMPOSE_PROJECT_NAME to _include the surrounding double-quotes_, and this _happened_ to work just because we were using this variable in shell commands, where the quoting would be handled as normal CLI quoting of a string. However, since we _also_ make this make variable available as environment variable (through the `export` command through which we set env vars from a dotenv file), this ended up breaking things from Compose v2.4 through this change: docker/compose#9332.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Take
COMPOSE_PROJECT_NAMEinto consideration on commandsRelated issue
Resolves #9316