Conversation
522a5cf to
d2f01a6
Compare
Contributor
Author
|
@ndeloof can I bother you to take a quick look at this or assign it to someone? |
ndeloof
approved these changes
May 2, 2022
Contributor
|
@Jille I don't know why the CI workflow din't start, but can you just push force on your branch to trigger the CI again? |
The down command silently ignored all arguments, which might cause confusion and/or outages if someone expects `docker-compose down $service` to be the opposite of `docker-compose up $service`, rather than turning down everything. Signed-off-by: Jille Timmermans <jille@quis.cx>
auto-merge was automatically disabled
May 2, 2022 13:28
Head branch was pushed to by a user without write access
Contributor
Author
Note that the push has disabled auto-merge. |
Contributor
|
No worries, that's fine now, I got the option to allow the CI build and re-added the auto-merge option 👍 |
piroux
added a commit
to piroux/docker-compose
that referenced
this pull request
Jul 16, 2022
Based on docker#9158 which enforced it for the down command
piroux
added a commit
to piroux/docker-compose
that referenced
this pull request
Jul 16, 2022
…version Based on docker#9158 which enforced it for the down command
piroux
added a commit
to piroux/docker-compose
that referenced
this pull request
Jul 16, 2022
…version Based on docker#9158 which enforced it for the down command Signed-off-by: piroux <pierre.roux01@gmail.com>
piroux
added a commit
to piroux/docker-compose
that referenced
this pull request
Jul 28, 2022
…version Based on docker#9158 which enforced it for the down command Signed-off-by: piroux <pierre.roux01@gmail.com>
dpeng817
added a commit
to dagster-io/dagster
that referenced
this pull request
Oct 19, 2022
…ture (#10042) ### Summary & Motivation A recent change to docker-compose down errors on additional arguments that were previously ignored (docker/compose#9158). We had our docker-compose down setup to exactly mirror docker-compose up, which is incorrect in the exact way that it seems like this PR seeks to avoid confusion, so this PR gets rid of that parity in the command. ### How I Tested These Changes Previously got errors on local spindown when using docker-compose, this fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The down command silently ignored all arguments, which might cause
confusion and/or outages if someone expects
docker-compose down $serviceto be the opposite ofdocker-compose up $service, ratherthan turning down everything.
What I did
Make docker-compose down reject any given arguments.
Related issue
closes #9151