Do not try to guess when to allocate a TTY and keep it as default#9035
Do not try to guess when to allocate a TTY and keep it as default#9035
Conversation
eb418ff to
5321188
Compare
|
I can't find a better fix for this, but still sad we have to give up with tty detection, and wonder this will trigger more issues from users who expect compose to automatically adjust to environment :-/ |
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
5321188 to
63fcd1a
Compare
|
@ndeloof Yep. I also tried to save the automatic behaviour, but without success... |
thaJeztah
left a comment
There was a problem hiding this comment.
SGTM
just to double-check; this brings it to the same behaviour / defaults as compose v1, correct?
|
Since panic is a result of this I don't think it's probably satisfactory, see https://stackoverflow.com/questions/70855915/fix-panic-provided-file-is-not-a-console-from-docker-compose-in-github-action |
|
I don't like this either. I expect we get rid of this as we share more code with docker/cli, especially relying on the exact same |
|
Right... but not preventing a panic? that doesn't seem like the right thing... |
|
We can burn some cycles trying to find a better way to manage this and avoid a |
|
Sounds good. I had actually planned long ago and half-implemented a switch to using docker's exec for |
|
Hello, i just tested with version 2.6.1 of docker compose and still having the issue. Once i remove exec with tee it starts working. |
What I did
Do not try to guess when to allocate a TTY and keep it as default
Related issue
Resolves #8908