Propagate GroupAdd from ServiceConfig to HostConfig#8987
Merged
Conversation
The `group_add` key is parsed correctly from a compose file, but it is not passed into the `ContainerCreate` API call, thus the configuration does not take effect. This commit fixes the issue by propagating the configuration from Docker compose's ServiceConfig to Docker container's HostConfig. Signed-off-by: Lance Chen <hello@lancechen.tw>
ndeloof
approved these changes
Dec 17, 2021
Contributor
|
nice, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The
group_addkey is parsed correctly from a compose file, but it is notpassed into the
ContainerCreateAPI call, thus the configuration doesnot take effect. This commit fixes the issue by propagating the
configuration from Docker compose's ServiceConfig to Docker container's
HostConfig.
Related issue
I think #8810 was not completely fixed when it was closed. The PR compose-spec/compose-go#201 that was considered the fix to #8810 only solved the first half part of the issue, which is parsing
group_addcorrectly, this PR solves the other half.