Skip to content

Fixed a typo in GroupAdd type mapping#201

Merged
mat007 merged 1 commit intocompose-spec:masterfrom
axhav:fix-groupadd
Nov 3, 2021
Merged

Fixed a typo in GroupAdd type mapping#201
mat007 merged 1 commit intocompose-spec:masterfrom
axhav:fix-groupadd

Conversation

@axhav
Copy link

@axhav axhav commented Nov 3, 2021

Found an issue that GroupAdd was not working with docker compose v2. This typo fix should restore "group_add" parameter to docker compose again.

Fixes docker/compose#8810

Signed-off-by: William Axhav Bratt william@axhav.se

@axhav axhav requested a review from ndeloof as a code owner November 3, 2021 11:21
Copy link
Contributor

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, thanks!

@mat007
Copy link
Contributor

mat007 commented Nov 3, 2021

You need to sign your commit though, see https://github.com/compose-spec/compose-go/pull/201/checks?check_run_id=4091727957

…sulting in GroupAdd not working

Signed-off-by: William Axhav Bratt <william@axhav.se>
@axhav
Copy link
Author

axhav commented Nov 3, 2021

Thanks for the quick reply, signing should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compose v2 does not respect the group_add field

2 participants