Skip to content

Add init container support#8122

Merged
aiordache merged 1 commit intodocker:masterfrom
ojab:add_init_containers
Apr 6, 2021
Merged

Add init container support#8122
aiordache merged 1 commit intodocker:masterfrom
ojab:add_init_containers

Conversation

@ojab
Copy link

@ojab ojab commented Feb 16, 2021

@ojab ojab force-pushed the add_init_containers branch 5 times, most recently from ad22ea9 to 6627435 Compare February 16, 2021 10:08
@ojab
Copy link
Author

ojab commented Feb 16, 2021

CI is failing with Cannot start service svc1: cgroups: cgroup mountpoint does not exist: unknown, tests locally are failing due to docker: Error response from daemon: manifest for dockerswarm/dind:20.10.3 not found: manifest unknown: manifest unknown., so let's send this to review and hope that CI will be fixed somehow.

@ojab ojab marked this pull request as ready for review February 16, 2021 10:32
@ojab ojab force-pushed the add_init_containers branch 2 times, most recently from 82d375b to 9be9320 Compare February 16, 2021 10:54
@ndeloof
Copy link
Contributor

ndeloof commented Feb 16, 2021

LGTM, but please amend your commits for sign-off or we can't accept contributions (git commit amend -s)

@ojab
Copy link
Author

ojab commented Feb 16, 2021

But there is a signoff already, dunno what DCO is expecting from me.

@ojab ojab force-pushed the add_init_containers branch from 9be9320 to c532d64 Compare February 16, 2021 11:28
@ojab
Copy link
Author

ojab commented Feb 16, 2021

Ok, it was expecting the same [real] name as a commit author, pushed with the changed name.

@ojab ojab marked this pull request as draft February 16, 2021 15:17
@ojab ojab force-pushed the add_init_containers branch 4 times, most recently from 2ee5e37 to 07e0014 Compare February 16, 2021 16:09
@ojab ojab marked this pull request as ready for review February 16, 2021 16:35
@ojab
Copy link
Author

ojab commented Feb 16, 2021

Set up test environment locally and reworked the PR to make it actually work, tests/integration/project_test.py tests pass here (test_up_with_nvidia_runtime is skipped, test_project_up_port_mappings_with_multiple_files fails due to local docker setup).
I've tried to add a test with dependency running top, but looks like project.up() wait for completion even with detached=True, so test hangs.

Ready for review, I guess?

@ojab
Copy link
Author

ojab commented Feb 16, 2021

And this time CI on Alpine is green, so I suppose it works 🎉

@ojab ojab force-pushed the add_init_containers branch from 07e0014 to 17a2331 Compare February 16, 2021 18:06
Fixes docker#6855

See compose-spec/compose-spec#134

Signed-off-by: Slava Kardakov <ojab@ojab.ru>
@ojab ojab force-pushed the add_init_containers branch from 17a2331 to 4daad05 Compare February 18, 2021 17:48
@ojab
Copy link
Author

ojab commented Feb 18, 2021

Rebased on master, CI is green now.

@aiordache aiordache added this to the 1.29.0 milestone Feb 25, 2021
Copy link
Contributor

@aiordache aiordache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ndeloof
Copy link
Contributor

ndeloof commented Apr 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Init Containers for Docker Compose

3 participants