Add a dependsOn condition to wait for successful completion#134
Merged
ndeloof merged 6 commits intocompose-spec:masterfrom Feb 5, 2021
Merged
Conversation
Signed-off-by: Michael Irwin <mikesir87@gmail.com> Resolves compose-spec#11
Collaborator
|
LGTM, two notes:
|
- Adjust service_finished_successfully to service_completed_successfully - Remove exit code text, as that's platform specific Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Contributor
Author
I had the same debate myself and like
Honestly, I'm trying to think of the scenario where someone might need that. If the dependent service failed, when would you still want the dependent service to run? Seems quite risky to me, but probably only because I can't think of a use case for it. |
ndeloof
approved these changes
Jan 28, 2021
Collaborator
ndeloof
left a comment
There was a problem hiding this comment.
don't forget to update the json schema to reflect this new value
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Contributor
Author
And done. Thanks @ndeloof! |
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
EricHripko
reviewed
Jan 30, 2021
Collaborator
|
also CC @kohidave |
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: ojab <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 16, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ojab
added a commit
to ojab/compose
that referenced
this pull request
Feb 18, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
ulyssessouza
pushed a commit
to timoxley/compose
that referenced
this pull request
Apr 6, 2021
Fixes docker#6855 See compose-spec/compose-spec#134 Signed-off-by: Slava Kardakov <ojab@ojab.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates the spec to add a
dependsOn.conditionthat waits for the successful completion of a dependent service. This is important to help support init container workflows.Which issue(s) this PR fixes:
Fixes #11