Allow overriding user on the command line#737
Closed
chmouel wants to merge 1 commit intodocker:masterfrom
chmouel:override-user
Closed
Allow overriding user on the command line#737chmouel wants to merge 1 commit intodocker:masterfrom chmouel:override-user
chmouel wants to merge 1 commit intodocker:masterfrom
chmouel:override-user
Conversation
|
Nice, thanks.
|
Allow overriding a user on the command line from the one specified in the fig.yaml We are testing on the behavior of how the busybox image is made which is kind of tricky but hopefully that shouln't change. Signed-off-by: Chmouel Boudjnah <chmouel@chmouel.com>
Author
|
Thanks @aanand, great suggestions |
|
@chmouel, this would be an awesome feature. Do you think you'll have a chance to finish it up? If not, I could take a crack at it. It looks like it's pretty darn close. |
Author
|
@IanVS feel free to take it over :) |
|
OK I think I have something that will work, but I'm not sure how to structure the assert of the test. To get the "User" as @aanand suggests, what should I do? What's the right way to do this? Thanks! |
|
Replaced by #971. Thanks! |
infraAnchor
pushed a commit
to infraAnchor/compose
that referenced
this pull request
Mar 6, 2026
Add SECURITY.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow overriding a user on the command line from the one specified in
the fig.yaml
Tests are a bit tricky since regenerating a docker image with multiple
users just for this is consuming so let's catch the error instead and
make sure it works.
Signed-off-by: Chmouel Boudjnah chmouel@chmouel.com