Skip to content

Fix volumes_from a service with no containers#456

Merged
aanand merged 1 commit intodocker:masterfrom
dnephin:volumes_from_service
Oct 1, 2014
Merged

Fix volumes_from a service with no containers#456
aanand merged 1 commit intodocker:masterfrom
dnephin:volumes_from_service

Conversation

@dnephin
Copy link

@dnephin dnephin commented Aug 30, 2014

Resolves #455

@thaJeztah
Copy link
Member

Nice!

Wondering; could there be edge-cases where people have an ONBUILD in their Dockerfile that will be triggered because of this? Not sure if this is something to make a special case for, but wanted to mention it in case somebody knows an example where a build can cause havoc 😉

Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin dnephin force-pushed the volumes_from_service branch from 74607b8 to f5d43b6 Compare September 5, 2014 02:25
@bfirsh bfirsh added this to the 1.0.0 milestone Sep 30, 2014
@bfirsh
Copy link

bfirsh commented Sep 30, 2014

LGTM

aanand added a commit that referenced this pull request Oct 1, 2014
Fix volumes_from a service with no containers
@aanand aanand merged commit 267be12 into docker:master Oct 1, 2014
@dnephin dnephin deleted the volumes_from_service branch October 1, 2014 01:44
yuval-k pushed a commit to yuval-k/compose that referenced this pull request Apr 10, 2015
Fix volumes_from a service with no containers
Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"volumes_from: service" fails silently if the service has no containers

4 participants