Merged
Conversation
Author
|
cc @moxiegirl |
|
Lots of good stuff. Purely on the basis of how frequently it's asked, I'm tempted to say we should put the one about waiting for containers to start at the very top, but that's a minor thing. LGTM |
There was a problem hiding this comment.
@dnephin not clear where the healthcheck is implemented in the application?
Author
|
I've applied those changes |
Signed-off-by: Daniel Nephin <dnephin@docker.com>
|
LGTM thank you @dnephin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of a FAQ document for Compose.
Fixes #895, and also answers a bunch of questions we see pretty frequently in IRC and stackoverflow.