Fix menu print when logs/menu number of lines change#11765
Merged
milas merged 1 commit intodocker:mainfrom Apr 24, 2024
Merged
Conversation
8dbb8a5 to
0cba9fe
Compare
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
0cba9fe to
d77a2ff
Compare
milas
approved these changes
Apr 24, 2024
Contributor
milas
left a comment
There was a problem hiding this comment.
Nice! This looks great, I can't repro any weird issues with it overlapping or appearing when it shouldn't after this.
Contributor
|
Merged when I was doing my review 😅 |
temenuzhka-thede
pushed a commit
to temenuzhka-thede/compose
that referenced
this pull request
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The is related with the clean up of the navigation menu which can be tricky when the number of lines change.
Removed all ClearLines and kept the cleaning of the menu inside shortcut.go. Please check the video.
Screen.Recording.2024-04-24.at.18.58.58.mov
Related issue
fixes #14021
https://docker.atlassian.net/jira/software/c/projects/COMP/boards/576?selectedIssue=COMP-536
(not mandatory) A picture of a cute animal, if possible in relation to what you did
