fix(desktop): remove overly-aggressive feature flag check#11748
Merged
milas merged 1 commit intodocker:mainfrom Apr 19, 2024
Merged
fix(desktop): remove overly-aggressive feature flag check#11748milas merged 1 commit intodocker:mainfrom
milas merged 1 commit intodocker:mainfrom
Conversation
Synchronized file share integration between Desktop & Compose is still experimental, so there's a feature flag. However, it's slightly more complex than that - not all OS/hypervisor combos support Synchronized file shares and it's an entitled feature, so the config API from Desktop covers all this logic. I accidentally left the old feature flag check in, but it's possible to opt-in via settings independent of the feature flag, which wasn't being respected. (That is, it's possible to enable the feature w/o the feature flag being on because of weirdness about how feature flags & settings work in Desktop currently.) Signed-off-by: Milas Bowman <milas.bowman@docker.com>
a924345 to
fa0b3d5
Compare
temenuzhka-thede
pushed a commit
to temenuzhka-thede/compose
that referenced
this pull request
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Synchronized file share integration between Desktop & Compose is still experimental, so there's a feature flag. However, it's slightly more complex than that - not all OS/hypervisor combos support Synchronized file shares and it's an entitled feature, so the config API from Desktop covers all this logic.
I accidentally left the old feature flag check in, but it's possible to opt-in via settings independent of the feature flag, which wasn't being respected. (That is, it's possible to enable the feature w/o the feature flag being on because of weirdness about how feature flags & settings work in Desktop currently.)
Related issue
https://docker.atlassian.net/browse/COMP-533
(not mandatory) A picture of a cute animal, if possible in relation to what you did
