Skip to content

include disabled services for shell completion#11251

Merged
glours merged 1 commit intodocker:mainfrom
ndeloof:completion_disabled
Dec 6, 2023
Merged

include disabled services for shell completion#11251
glours merged 1 commit intodocker:mainfrom
ndeloof:completion_disabled

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 6, 2023

What I did
As invoking a service name explicitly does enable it without the need to pass a profile, those should be offered as candidates by shell completion

Related issue
close #11245

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@codecov
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ae4fd79) 56.40% compared to head (02db36f) 56.33%.
Report is 1 commits behind head on main.

❗ Current head 02db36f differs from pull request most recent head bdbda79. Consider uploading reports for the commit bdbda79 to get more accurate results

Files Patch % Lines
cmd/compose/completion.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11251      +/-   ##
==========================================
- Coverage   56.40%   56.33%   -0.07%     
==========================================
  Files         134      134              
  Lines       11560    11560              
==========================================
- Hits         6520     6512       -8     
- Misses       4401     4407       +6     
- Partials      639      641       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours glours force-pushed the completion_disabled branch from 02db36f to bdbda79 Compare December 6, 2023 08:38
@glours glours enabled auto-merge December 6, 2023 08:38
@glours glours merged commit 30e80d2 into docker:main Dec 6, 2023
ndeloof pushed a commit to ndeloof/compose that referenced this pull request Dec 7, 2023
include disabled services for shell completion

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof deleted the completion_disabled branch December 20, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Bash completion doesn't work using profiles

2 participants