Make volumes_from and net containers first class dependencies#1076
Merged
aanand merged 1 commit intodocker:masterfrom Mar 13, 2015
gilclark:master
Merged
Make volumes_from and net containers first class dependencies#1076aanand merged 1 commit intodocker:masterfrom gilclark:master
aanand merged 1 commit intodocker:masterfrom
gilclark:master
Conversation
assure that starting order is correct. Added supporting unit and integration tests as well. Signed-off-by: Gil Clark <gilclark1@gmail.com>
There was a problem hiding this comment.
If any of these tests fail the containers won't get killed or removed, which I guess is also a problem with many of the existing tests.
We should probably add
def setUp(self):
self.cleanup_projects = []
def tearDown(self):
for project in self.cleanup_projects:
project.kill()
project.remove_stopped()And in each test case that uses this, add the project to the list immediately after creating it.
project = ...
self.cleanup_projects.append(project)|
LGTM One issue with testing, which is actually a problem with many of the tests we have in that module already, so I guess it's not critical that it gets fixed in this branch. |
Author
|
I did notice that. I have to clean up a lot of containers after the tests. I did worry that containers that aren't cleaned up would pollute and fail the following tests or a rerun of the same tests but I've never seen that happen. |
3 tasks
|
Looks like the build passes: https://app.wercker.com/#build/54fa1d90d56c0f8a1d034e24 LGTM |
aanand
added a commit
that referenced
this pull request
Mar 13, 2015
Make volumes_from and net containers first class dependencies
|
Hmm, build passes on Wercker but I get this locally: |
|
I think this might be related moby/moby#9340 Seems like there is some condition where links can cause |
|
Yep. See #1108. |
yuval-k
pushed a commit
to yuval-k/compose
that referenced
this pull request
Apr 10, 2015
Make volumes_from and net containers first class dependencies Signed-off-by: Yuval Kohavi <yuval.kohavi@gmail.com>
This was referenced Sep 1, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make volumes_from and net containers first class dependencies and assure that starting order is correct. Added supporting unit and integration tests as well.
Signed-off-by: Gil Clark gilclark1@gmail.com