Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3d4129b
Choose a base ref
...
head repository: docker/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eedd969
Choose a head ref
  • 13 commits
  • 13 files changed
  • 3 contributors

Commits on Nov 12, 2025

  1. cli/command/system: define struct for formatting version

    The client.ServerVersion method in the moby/client module defines
    an output struct that's separate from the API response. These output
    structs are not designed to be marshaled as JSON, but the CLI depended
    on them defining `json` labels, which it used to format the output
    as JSON (`docker version --format=json`); as a result, the JSON output
    changed in docker v29, as it would now use the naming based on the Go
    struct's fields (`APIVersion` instead of `ApiVersion`).
    
    In future, we should consider having a `--raw` (or similar) option for
    the CLI to print API responses as-is, instead of using client structs
    or CLI structs for this (this would also make sure the JSON output does
    not inherit client-side formatting of fields).
    
    For now, let's create a struct for formatting the output, similar to what
    we do for the client-side information.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Nov 12, 2025
    Configuration menu
    Copy the full SHA
    bff56f0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #6648 from thaJeztah/cli_version_json_format

    cli/command/system: define struct for formatting version
    thaJeztah authored Nov 12, 2025
    Configuration menu
    Copy the full SHA
    c44e8a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2025

  1. image/tree: Fix untagged images in non-expanded view

    In the expanded view there is a separate image entry per each tag.
    
    Fix a bug which caused no entry to be added for untagged images.
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    b66b931 View commit details
    Browse the repository at this point in the history
  2. image/tree: Don't limit name width if non tty

    Previously when no terminal was attached the width was assumed to be 80.
    This is too short for most image names which truncated the names when
    output was redirect (for example to `grep`).
    
    This disabled the name truncation if the terminal width can't be
    determined.
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    aa5d00a View commit details
    Browse the repository at this point in the history
  3. image/list: Print legend only if limiting width

    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    ed281dd View commit details
    Browse the repository at this point in the history
  4. Merge pull request #6656 from vvoland/img-list-notty-width

    image/tree: Don't limit name width if non tty
    thaJeztah authored Nov 13, 2025
    Configuration menu
    Copy the full SHA
    2ae51e2 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #6657 from vvoland/img-list-nonexpanded-untagged

    image/tree: Fix untagged images in non-expanded view
    thaJeztah authored Nov 13, 2025
    Configuration menu
    Copy the full SHA
    88e3241 View commit details
    Browse the repository at this point in the history
  6. image/tree: Respect NO_COLOR env variable

    Do not use the fancy colored output if NO_COLOR variable is set to 1
    following the https://no-color.org/ convention.
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    be9e630 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #6654 from vvoland/img-list-nocolor

    image/tree: Respect NO_COLOR env variable
    thaJeztah authored Nov 13, 2025
    Configuration menu
    Copy the full SHA
    2cfd9df View commit details
    Browse the repository at this point in the history
  8. image/tree: Only show untagged images when --all flag is used

    In non-expanded view, untagged images should only be displayed when the
    --all flag is explicitly provided by the user.
    
    Previously, untagged images were accidentally always shown in the
    non-expanded view regardless of the --all flag setting.
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    207bf52 View commit details
    Browse the repository at this point in the history
  9. Merge pull request #6658 from vvoland/img-list-all-dangling

    image/tree: Only show untagged images when --all flag is used
    vvoland authored Nov 13, 2025
    Configuration menu
    Copy the full SHA
    67cef77 View commit details
    Browse the repository at this point in the history
  10. cli/command/system: Fix missing components in version output

    The `Components` weren't actually copied to the output struct.
    
    Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
    vvoland committed Nov 13, 2025
    Configuration menu
    Copy the full SHA
    dd2c493 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #6659 from vvoland/fix-system-version

    cli/command/system: Fix missing components in version output
    thaJeztah authored Nov 13, 2025
    Configuration menu
    Copy the full SHA
    eedd969 View commit details
    Browse the repository at this point in the history
Loading