Skip to content

tests: share single docker between docker-container backends#1890

Merged
jedevc merged 4 commits intodocker:masterfrom
jedevc:tests-share-docker-container-backend
Jun 20, 2023
Merged

tests: share single docker between docker-container backends#1890
jedevc merged 4 commits intodocker:masterfrom
jedevc:tests-share-docker-container-backend

Conversation

@jedevc
Copy link
Copy Markdown
Collaborator

@jedevc jedevc commented Jun 16, 2023

⚠️ Requires moby/buildkit#3954.

This means that we can run our docker-container tests in parallel again, which can help speed up our test runs by a significant amount.

@jedevc jedevc requested review from crazy-max and tonistiigi June 16, 2023 10:38
jedevc added 4 commits June 20, 2023 12:27
Signed-off-by: Justin Chadwell <me@jedevc.com>
This means that we can run our docker-container tests in parallel again,
which can help speed up our test runs by a *significant* amount.

Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
This should help reduce any unexpected config conflict between workers.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the tests-share-docker-container-backend branch from 0d25e4d to 6f394a0 Compare June 20, 2023 11:41
@jedevc jedevc marked this pull request as ready for review June 20, 2023 11:41
Copy link
Copy Markdown
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@jedevc jedevc merged commit 010e4c8 into docker:master Jun 20, 2023
@jedevc jedevc deleted the tests-share-docker-container-backend branch June 20, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants