tests: add worker cleanup method to interface#3954
Merged
jedevc merged 1 commit intomoby:masterfrom Jun 20, 2023
Merged
Conversation
22108d3 to
6ef0e1f
Compare
tonistiigi
reviewed
Jun 19, 2023
Member
tonistiigi
left a comment
There was a problem hiding this comment.
nitpick: is Close() error more standard naming convention for this functionality?
This is so that we can allow workers to provision and manage resources that have a lifetime greater than a single sandbox. Although none of our current workers currently implement this method, we want to implement this for buildx downstream to allow reusing docker daemons between docker-container workers. Signed-off-by: Justin Chadwell <me@jedevc.com>
6ef0e1f to
a629467
Compare
Member
Author
SGTM. No strong opinions as to naming here. |
crazy-max
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so that we can allow workers to provision and manage resources that have a lifetime greater than a single sandbox.
Although none of our current workers currently implement this method, we want to implement this for buildx downstream to allow reusing docker daemons between docker-container workers.