Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: docker/buildx
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.10.2
Choose a base ref
...
head repository: docker/buildx
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.10.3
Choose a head ref
  • 13 commits
  • 13 files changed
  • 4 contributors

Commits on Feb 8, 2023

  1. bake: fix loop references

    Signed-off-by: Justin Chadwell <me@jedevc.com>
    (cherry picked from commit 48357ee)
    jedevc authored and crazy-max committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b66988c View commit details
    Browse the repository at this point in the history
  2. builder: fix docker context not validated

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    (cherry picked from commit 0e544fe)
    crazy-max committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ae278ce View commit details
    Browse the repository at this point in the history
  3. build: add docs for boolean attestation flags

    Signed-off-by: Justin Chadwell <me@jedevc.com>
    (cherry picked from commit 07548bc)
    jedevc authored and crazy-max committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    582cc04 View commit details
    Browse the repository at this point in the history
  4. bake: avoid early-exit for resolution failures

    With changes made to allow lazy evaluation, we were early exiting if an
    undefined name was detected, either for a variable or a function.
    
    This had two key implications:
    
    1. The error messages changed, and became significantly less
       informative.
    
       For example, we went from:
    
       > Unknown variable; There is no variable named "FO". Did you mean "FOO"?, and 1 other diagnostic(s)
    
       To
    
       > Invalid expression; undefined variable "FO"
    
    2. Any issues in our function detection from funcCalls which cause JSON
       functions to be erroneously detected cause invalid functions to be
       resolved, which causes new name resolution errors.
    
    To avoid the above problems, we can defer the error from an undefined
    name until HCL evaluation - which produces the more informative errors,
    and does not suffer from incorrectly detecting JSON functions.
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    (cherry picked from commit dc8a2b0)
    jedevc authored and crazy-max committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    cc87bd1 View commit details
    Browse the repository at this point in the history
  5. gitutil: override the locale to ensure consistent output

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    (cherry picked from commit a8eb2a7)
    crazy-max committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    02cf539 View commit details
    Browse the repository at this point in the history
  6. build: check reachable git commits

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    (cherry picked from commit fd58841)
    crazy-max committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    661af29 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. bake: avoid nesting error diagnostics

    With changes to the lazy evaluation, the evaluation order is no longer
    fixed - this means that we can follow long and confusing paths to get to
    an error.
    
    Because of the co-recursive nature of the lazy evaluation, we need to
    take special care that the original HCL diagnostics are not discarded
    and are preserved so that the original source of the error can be
    detected. Preserving the full trace is not necessary, and probably not
    useful to the user - all of the file that is not lazily loaded will be
    eagerly loaded after all struct blocks are loaded - so the error would
    be found regardless.
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    (cherry picked from commit fbb4f4d)
    jedevc authored and crazy-max committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    0fad89c View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. imagetools: process com.docker.reference.* annotations

    To give us the option later down the road of producing recommended OCI
    names in BuildKit (using com instead of vnd, woops), we need to update
    Buildx to be able to process both.
    
    Ideally, if a Buildx/BuildKit release hadn't been made we could just
    switch over, but since we have, we'd need to support both (at least for
    a while, eventually we could consider deprecating+removing the vnd
    variant).
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    (cherry picked from commit 642f28f)
    jedevc authored and crazy-max committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    a73d07f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1609 from crazy-max/0.10.3_cherry_picks

    [v0.10] cherry-picks for v0.10.3
    crazy-max authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    f2feea8 View commit details
    Browse the repository at this point in the history
  3. Remove git warning: buildx/1633

    Signed-off-by: David Gageot <david.gageot@docker.com>
    (cherry picked from commit d4a4aaf)
    dgageot authored and crazy-max committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    45863c4 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1635 from crazy-max/v0.10_backport_fix-git-ambiguous

    [v0.10 backport] build: fix git ambiguous argument
    crazy-max authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b5b9de6 View commit details
    Browse the repository at this point in the history
  5. ci: update buildx and buildkit to latest

    Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
    (cherry picked from commit f1a5a3e)
    crazy-max committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    c960d16 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1636 from crazy-max/v0.10_backport_ci-update-ver

    [v0.10 backport] ci: update buildx and buildkit to latest
    crazy-max authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    79e156b View commit details
    Browse the repository at this point in the history
Loading