-
Notifications
You must be signed in to change notification settings - Fork 626
Comparing changes
Open a pull request
base repository: docker/buildx
base: 00ed17d
head repository: docker/buildx
compare: 79e156b
- 13 commits
- 13 files changed
- 4 contributors
Commits on Feb 8, 2023
-
Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit 48357ee)
Configuration menu - View commit details
-
Copy full SHA for b66988c - Browse repository at this point
Copy the full SHA b66988cView commit details -
builder: fix docker context not validated
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit 0e544fe)
Configuration menu - View commit details
-
Copy full SHA for ae278ce - Browse repository at this point
Copy the full SHA ae278ceView commit details -
build: add docs for boolean attestation flags
Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit 07548bc)
Configuration menu - View commit details
-
Copy full SHA for 582cc04 - Browse repository at this point
Copy the full SHA 582cc04View commit details -
bake: avoid early-exit for resolution failures
With changes made to allow lazy evaluation, we were early exiting if an undefined name was detected, either for a variable or a function. This had two key implications: 1. The error messages changed, and became significantly less informative. For example, we went from: > Unknown variable; There is no variable named "FO". Did you mean "FOO"?, and 1 other diagnostic(s) To > Invalid expression; undefined variable "FO" 2. Any issues in our function detection from funcCalls which cause JSON functions to be erroneously detected cause invalid functions to be resolved, which causes new name resolution errors. To avoid the above problems, we can defer the error from an undefined name until HCL evaluation - which produces the more informative errors, and does not suffer from incorrectly detecting JSON functions. Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit dc8a2b0)
Configuration menu - View commit details
-
Copy full SHA for cc87bd1 - Browse repository at this point
Copy the full SHA cc87bd1View commit details -
gitutil: override the locale to ensure consistent output
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit a8eb2a7)
Configuration menu - View commit details
-
Copy full SHA for 02cf539 - Browse repository at this point
Copy the full SHA 02cf539View commit details -
build: check reachable git commits
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit fd58841)
Configuration menu - View commit details
-
Copy full SHA for 661af29 - Browse repository at this point
Copy the full SHA 661af29View commit details
Commits on Feb 9, 2023
-
bake: avoid nesting error diagnostics
With changes to the lazy evaluation, the evaluation order is no longer fixed - this means that we can follow long and confusing paths to get to an error. Because of the co-recursive nature of the lazy evaluation, we need to take special care that the original HCL diagnostics are not discarded and are preserved so that the original source of the error can be detected. Preserving the full trace is not necessary, and probably not useful to the user - all of the file that is not lazily loaded will be eagerly loaded after all struct blocks are loaded - so the error would be found regardless. Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit fbb4f4d)
Configuration menu - View commit details
-
Copy full SHA for 0fad89c - Browse repository at this point
Copy the full SHA 0fad89cView commit details
Commits on Feb 16, 2023
-
imagetools: process com.docker.reference.* annotations
To give us the option later down the road of producing recommended OCI names in BuildKit (using com instead of vnd, woops), we need to update Buildx to be able to process both. Ideally, if a Buildx/BuildKit release hadn't been made we could just switch over, but since we have, we'd need to support both (at least for a while, eventually we could consider deprecating+removing the vnd variant). Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit 642f28f)
Configuration menu - View commit details
-
Copy full SHA for a73d07f - Browse repository at this point
Copy the full SHA a73d07fView commit details -
Merge pull request #1609 from crazy-max/0.10.3_cherry_picks
[v0.10] cherry-picks for v0.10.3
Configuration menu - View commit details
-
Copy full SHA for f2feea8 - Browse repository at this point
Copy the full SHA f2feea8View commit details -
Remove git warning: buildx/1633
Signed-off-by: David Gageot <david.gageot@docker.com> (cherry picked from commit d4a4aaf)
Configuration menu - View commit details
-
Copy full SHA for 45863c4 - Browse repository at this point
Copy the full SHA 45863c4View commit details -
Merge pull request #1635 from crazy-max/v0.10_backport_fix-git-ambiguous
[v0.10 backport] build: fix git ambiguous argument
Configuration menu - View commit details
-
Copy full SHA for b5b9de6 - Browse repository at this point
Copy the full SHA b5b9de6View commit details -
ci: update buildx and buildkit to latest
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> (cherry picked from commit f1a5a3e)
Configuration menu - View commit details
-
Copy full SHA for c960d16 - Browse repository at this point
Copy the full SHA c960d16View commit details -
Merge pull request #1636 from crazy-max/v0.10_backport_ci-update-ver
[v0.10 backport] ci: update buildx and buildkit to latest
Configuration menu - View commit details
-
Copy full SHA for 79e156b - Browse repository at this point
Copy the full SHA 79e156bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 00ed17d...79e156b