github(summary): use relative path for artifact link and fix filename#368
Merged
crazy-max merged 3 commits intodocker:mainfrom Jun 18, 2024
Merged
Conversation
7699014 to
4ed6ff4
Compare
crazy-max
commented
Jun 17, 2024
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| CTN_BUILDER_NAME: ${{ steps.builder.outputs.name }} | ||
| TEST_FOR_SUMMARY: ${{ secrets.TEST_FOR_SUMMARY }} |
Member
Author
There was a problem hiding this comment.
This dummy secret is used for testing the behavior of a user having repo name as secret value.
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
b18d6c1 to
e8efdb8
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
e8efdb8 to
edcf239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #367
Use relative path for artifact link to avoid broken links.
Summary example from integration tests: https://github.com/docker/actions-toolkit/actions/runs/9554693648#summary-26336341867
Artifact link: https://github.com/docker/actions-toolkit/actions/runs/9554693648/artifacts/1610289579
Raw output: https://github.com/docker/actions-toolkit/actions/runs/9554693648/jobs/19145276140/summary_raw
Added extra commit to convert
.dockerbuildfilename and build name in the summary to unicode entities.Has been tested on a private repo where a secret value is part of the
.dockerbuildfilename:In this case
test-docker-actionis used as secret value. Here is the raw output of the summary: