Skip to content

summary: .dockerbuild link broken #367

@crazy-max

Description

@crazy-max

Was looking at people updating to latest v6 of build-push-action and saw this summary generation: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951

Seems like the username/handle is used as secret: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/workflow#L17

          username: ${{ secrets.DOCKERHUB_USERNAME }}

And therefore any part of the summary containing the secret value is redacted which breaks .dockerbuild link:

https://github.com/***/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534

And global rendering of the summary:

image

Corrected link is: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534

Which returns the right .dockerbuild filename as we upload the object with Content-Disposition header that is unredacted:

blobContentDisposition: `attachment; filename="${artifactName}"`

So we just need to fix the link.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions