-
Notifications
You must be signed in to change notification settings - Fork 41
Description
Was looking at people updating to latest v6 of build-push-action and saw this summary generation: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951
Seems like the username/handle is used as secret: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/workflow#L17
username: ${{ secrets.DOCKERHUB_USERNAME }}And therefore any part of the summary containing the secret value is redacted which breaks .dockerbuild link:
https://github.com/***/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534
And global rendering of the summary:
Corrected link is: https://github.com/jcgillespie/mssql-sqlpackage-docker/actions/runs/9547273951/artifacts/1608307534
Which returns the right .dockerbuild filename as we upload the object with Content-Disposition header that is unredacted:
Line 144 in 7b876a9
| blobContentDisposition: `attachment; filename="${artifactName}"` |
So we just need to fix the link.
