Skip to content

Stack overflow#6598

Merged
valadas merged 15 commits intodnnsoftware:developfrom
bdukes:stack-overflow
Jun 18, 2025
Merged

Stack overflow#6598
valadas merged 15 commits intodnnsoftware:developfrom
bdukes:stack-overflow

Conversation

@bdukes
Copy link
Copy Markdown
Contributor

@bdukes bdukes commented Jun 16, 2025

Fixes #6595

@bdukes bdukes added this to the 10.0.2 milestone Jun 16, 2025
valadas
valadas reviewed Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an initial review and nothing sticks out except the failed build

@bdukes bdukes mentioned this pull request Jun 16, 2025
Merged
3 tasks
@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Jun 17, 2025

I've pushed a few more commits which should resolve the test failures.

@bdukes bdukes force-pushed the stack-overflow branch 3 times, most recently from d734a56 to 693e9de Compare June 17, 2025 16:37
@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Jun 17, 2025

Okay, now it's really for real building successfully

valadas
valadas approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I have tested a clean install and an upgrade and they both worked out fine.
I did encounter an issue that may or may not be related to this PR and documented in #6601 but unless it rings a bell I'd suggest merging this an tackling the other issue separately.

@bdukes
Copy link
Copy Markdown
Contributor Author

bdukes commented Jun 17, 2025

Awesome, I have tested a clean install and an upgrade and they both worked out fine. I did encounter an issue that may or may not be related to this PR and documented in #6601 but unless it rings a bell I'd suggest merging this an tackling the other issue separately.

There is not a connection that immediately jumps out at me.

donker
donker approved these changes Jun 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@donker donker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valadas valadas merged commit 81d031b into dnnsoftware:develop Jun 18, 2025
2 checks passed
@bdukes bdukes deleted the stack-overflow branch June 18, 2025 16:51
@valadas valadas modified the milestones: 10.0.2, 10.1.0 Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@donker donker donker approved these changes

@valadas valadas valadas approved these changes

Assignees

No one assigned

Labels

Type: Bug

Projects

None yet

Milestone

10.1.0

Development

Successfully merging this pull request may close these issues.

[Bug]: Current develop branch StackOverflow before installation

3 participants

@bdukes @donker @valadas