Resolve build failure when SSMS is installed#6575
Merged
mitchelsellers merged 1 commit intodnnsoftware:developfrom Jun 13, 2025
Merged
Resolve build failure when SSMS is installed#6575mitchelsellers merged 1 commit intodnnsoftware:developfrom
mitchelsellers merged 1 commit intodnnsoftware:developfrom
Conversation
Contributor
|
Looks like CI did not like it though... |
Contributor
Author
|
Weird. I adjusted it a smidge and it looks to be working. |
6a420d4 to
4bac38d
Compare
mitchelsellers
approved these changes
Jun 13, 2025
corbob
added a commit
to corbob/Chocolatey.Cake.Recipe
that referenced
this pull request
Dec 4, 2025
This commit updates the logic for detecting the MSBuild tool. Our builds encountered this issue: NuGet/Home#14349. While investigating it, it was found that dnnsoftware encounted a similar issue and fixed it here: dnnsoftware/Dnn.Platform#6575. This commit updates the methods we use to call VSWhere to identify the MSBuild to return based on actually having an MSBuild.exe file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After installing SQL Server Management Studio (SSMS) 21, I noticed that I started getting errors during the build of the platform. SSMS 21 started using the Visual Studio Installer to manage installations and updates, so it appears that NuGet is finding and using its version of MSBuild instead of Visual Studio's.
This PR uses
vswhereto find the latest Visual Studio version and pass that toNuGet.exeSee also NuGet/Home#14349