Imports css-variables into Persona Bar main styles#6279
Imports css-variables into Persona Bar main styles#6279valadas merged 35 commits intodnnsoftware:release/10.0.0from
Conversation
This replaces hardcoded values in the PersonaBar main styles to use the dnn css-variables which allows matching branding. - The previous way to provide a PersonaBar theme still works, so if implementors want their own style to stay unchanged no matter what portal the admin UI is accessed from, that can still work by using actual values instead of the css variables. - This does not yet include the common components and the modules themselves, I'll do that in other PRs.
david-poindexter
left a comment
There was a problem hiding this comment.
@valadas I attempted to start correcting some of these in the browser as suggestions, but it was just bombing out the browser, so maybe you could update the others in your branch and push a new commit now that you see what went wrong?
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Library/Dnn.PersonaBar.UI/admin/personaBar/css/main.css
Outdated
Show resolved
Hide resolved
…/css/theme.css Co-authored-by: David Poindexter <dpoindexter@nvisionative.com>
|
@david-poindexter I ran the file through prettier to bring back all those semi-colons which also made some great enhancements for readability on long rgba funcitons using long variables names, etc. See 3f82fc6 for only this diff, or just let me know what you think with the current state. I also removed 2 usages of color-mix which is a bit flagship for browsers. |
Oh yeah - this looks MUCH better! |
david-poindexter
left a comment
There was a problem hiding this comment.
Awesome - thanks @valadas 🎉
This adds support for css variables to the react common components. I needed the changes from dnnsoftware#6279 in order to be able to on this. So if it is merged before this one, it becomes easier to review. If not and this one is merged, then this one includes it.
|
Soo, when rebasing I accidently pushed this commit directly to release/10.0.0 by accident. @dnnsoftware/approvers if there are any concerns with this PR, I can fix that in #6291 Or I can revert the commit if you guys prefer and resubmit this PR. |
Thanks for the heads up. I think this PR is just fine though and most likely nobody would have issues with it. Let me know if you need my help with anything should someone want this to be reverted. |
This replaces hardcoded values in the PersonaBar main styles to use the dnn css-variables which allows matching branding.
Out of box style (very similar to original)
With a different color theme (to match the site under it):
