Fixes to sql script and new rollup scripts for version 10#6038
Merged
mitchelsellers merged 3 commits intodnnsoftware:release/10.0.0from Jul 9, 2024
Merged
Fixes to sql script and new rollup scripts for version 10#6038mitchelsellers merged 3 commits intodnnsoftware:release/10.0.0from
mitchelsellers merged 3 commits intodnnsoftware:release/10.0.0from
Conversation
Contributor
|
@donker This looks awesome, I'll test the build results in Azure in the next few days, very curious to see how much this helps install |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
valadas
approved these changes
Jul 9, 2024
Contributor
valadas
left a comment
There was a problem hiding this comment.
I tested a clean install on SQL Server 2017 and everything worked fine. I tried an upgrade and it failed with ICSharpCode.SharpZipLib wich is probably unrelated. So I think this is good since it would only apply to clean installs anyway
mitchelsellers
approved these changes
Jul 9, 2024
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Feb 16, 2025
In dnnsoftware#6038 a rollup script was put in place to revamp our clean installation logic, get rid of some upgrade logic and potentially speed up installs, etc. In RC1 issue dnnsoftware#6364 was reported. I spent quite a lot of time trying to figure it out. Had to do a `git bisect` and it identified the commit of the rollup script as being the first commit to cause that issue. After a lot of head scratching I realized that the code in upgrade.cs was the one creating the virtual host page that should hold the module that allows editing user profiles from the Persona Bar. This solved the issue for HOST users but not for admins. For admins, this lives in the portal templates, it was cleaned up from modules we don't want, but this one needed to be brought back as the Persona Bar needs it for admins. As I was in upgrade.cs I though since we will document in our upgrade steps to upgrade to latest v9 before going to v10, we can get rid of all the other upgrade logic for all versions <10 in there. Closes dnnsoftware#6364
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Apr 14, 2025
I did a `git bisect` which pointed me to the commits in dnnsoftware#6038 to rollup the sql scripts for v10. This made no sense to me since it's not really related to web.config and @uzmannazari pointed out in dnnsoftware#6503 that a similar issue was caused by the LocalizationModule missing from the web.config. Also I could not reproduce the issue on upgrades. Then I thought since we have that v10 rollup, it uses the 10.00.00.config for the web.config xml merge scripts and up. Investigating the commit history of that file and comparing with 9.8.0 one I found that in dnnsoftware#4251, a bugfix was done to insure that the LocalizationModule is right after the UrlRewriteModule. This means tha upon upgrades it would be in the right place but with clean installs, that would never run and it was also missing from the base web.config, thus making it not be there at all. I was debating between putting this fix in the 10.00.00.config or just in the web.config I thought the web.config is fine as upon upgrades, the order would already have been fixed (as long as we document to upgrade to latest v9 before upgrading to v10). For clean installs it would just already be at the right place to start with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few missing objectQualifiers from the v10 SQL script and replaces the old 8.0.4 rollup scripts with a new one for v10.
Methodology for creating the rollup scripts
Note with item 2: DNN runs "Schema", then "Data" and then all scripts higher than 8.0.4 (starting thus with 08.00.04.01). This process was mimicked using a console app to isolate the exact process.
Note this will probably resolve issue #6028