Move DnnDeprecatedAttribute to Abstractions#5816
Merged
valadas merged 1 commit intodnnsoftware:release/9.13.0from Sep 20, 2023
Merged
Move DnnDeprecatedAttribute to Abstractions#5816valadas merged 1 commit intodnnsoftware:release/9.13.0from
valadas merged 1 commit intodnnsoftware:release/9.13.0from
Conversation
Closed
2 tasks
valadas
approved these changes
Sep 19, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Awesome, thanks so much, I'll test out the artififact but from reading, it looks good to me...
1377ad1 to
287dff3
Compare
In order for projects to not require a full reference to the source generator project, the attribute cannot be defined in the project. The first attempt to resolve this was to generate the attribute via the source generator itself, but since the Library project exposes its internals to other projects (e.g. DotNetNuke.HttpModules), this resulted in ambiguous references. As a result, moving the type to a project that all other projects can reference seemed to be the best compromise. Since the attribute is conditional, it doesn't affect the public API of that project. Fixes dnnsoftware#5815
287dff3 to
89bd59a
Compare
Contributor
Author
|
@valadas see the updated description, I had to adjust the approach here |
mitchelsellers
approved these changes
Sep 19, 2023
Contributor
|
I have downloaded the build from this PR and was able to upgrade fine from 9.12 and can confirm this is no longer an issue. Thanks so much @bdukes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order for projects to not require a full reference to the source generator project, the attribute cannot be defined in the project. The first attempt to resolve this was to generate the attribute via the source generator itself, but since the Library project exposes its internals to other projects (e.g. DotNetNuke.HttpModules), this resulted in ambiguous references. As a result, moving the type to a project that all other projects can reference seemed to be the best compromise. Since the attribute is conditional, it doesn't affect the public API of that project.
Fixes #5815