-
-
Notifications
You must be signed in to change notification settings - Fork 773
[Bug]: v9.13.0-rc1 has System.Runtime.CompilerServices.Unsafe in bin folder of upgrade zip #5815
Copy link
Copy link
Closed
Description
Is there an existing issue for this?
- I have searched the existing issues
What happened?
Upgrading a site that had a module using System.Runtime.CompilerServices.Unsafe properly defined it manifest, I got a binding redirect error. The dll got replaced by DNN upgrade zip.
Steps to reproduce?
- Install a clean DNN v9.12.x
- Install a module with System.Runtime.CompilerServices.Unsafe properly defined in its manifest
- Confirm the binding redirect works in the web.config after installing the module
- Upgrade to DNN v9.13.0
- Notice the installer does not fire and a binding redirect error regarding that dependency
Current Behavior
The DNN v9.13 upgrade.zip has System.Runtime.CompilerServices.Unsafe in its bin folder
Expected Behavior
Either that file is there by mistake (I only saw that dependency on DNN side of things in tests)
or
We should have a package for it so binding redirects are updated.
Relevant log output
No response
Anything else?
No response
Affected Versions
9.13.0 (release candidate)
What browsers are you seeing the problem on?
Chrome
Code of Conduct
- I agree to follow this project's Code of Conduct
Reactions are currently unavailable