Fix unintentional recursion (i.e. stack overflow)#5578
Merged
valadas merged 2 commits intodnnsoftware:developfrom Mar 16, 2023
Merged
Fix unintentional recursion (i.e. stack overflow)#5578valadas merged 2 commits intodnnsoftware:developfrom
valadas merged 2 commits intodnnsoftware:developfrom
Conversation
mitchelsellers
approved these changes
Mar 16, 2023
valadas
reviewed
Mar 16, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Looks like a nice refactoring but I am failing to figure out what the recursion problem was...
Contributor
Author
|
Sorry, the first commit has the fix, the others were just little things I saw as I checked some other controls nearby. diff --git a/DNN Platform/Library/UI/UserControls/URLTrackingControl.cs b/DNN Platform/Library/UI/UserControls/URLTrackingControl.cs
index 6bc2e43a3ab..d3c84980fd5 100644
--- a/DNN Platform/Library/UI/UserControls/URLTrackingControl.cs
+++ b/DNN Platform/Library/UI/UserControls/URLTrackingControl.cs
@@ -125,7 +125,7 @@ public int ModuleID
{
get
{
- int moduleID = this.ModuleID;
+ int moduleID = this.moduleID;
if (moduleID == -2)
{
if (this.Request.QueryString["mid"] != null) |
valadas
approved these changes
Mar 16, 2023
Contributor
valadas
left a comment
There was a problem hiding this comment.
Oh I see, thanks, makes perfect sense now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ModuleIDproperty ofURLTrackingControlreferences itself and so always loops forever whenever it's read.Fixes #5577
Fixes DNNCommunity/DNN.Documents#22