Added support for a Notes field in IP Filters#5411
Merged
mitchelsellers merged 4 commits intodnnsoftware:developfrom Nov 28, 2022
Merged
Added support for a Notes field in IP Filters#5411mitchelsellers merged 4 commits intodnnsoftware:developfrom
mitchelsellers merged 4 commits intodnnsoftware:developfrom
Conversation
Closes dnnsoftware#4140 Hosts can now set a note with each IP Filter rule to remind them about the purpose of each rule.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
david-poindexter
approved these changes
Nov 27, 2022
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Awesome @valadas - thank you!
mitchelsellers
approved these changes
Nov 28, 2022
mitchelsellers
approved these changes
Nov 28, 2022
Contributor
|
Nice one. Did you notice, @Tychodewaard ? |
valadas
added a commit
that referenced
this pull request
Feb 19, 2023
In #5411 , notes were added to the login ip filters and that needed an .SqlDataProvider file. In this project, those files are defined one by one in the manifest and I missed that. This PR adds it in there so it actually gets packaged in the zip.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4140
Hosts can now set a note with each IP Filter rule to remind them about the purpose of each rule.