Skip to content

Improve server screen UI#5152

Merged
mitchelsellers merged 2 commits intodnnsoftware:developfrom
donker:smptset
Jun 22, 2022
Merged

Improve server screen UI#5152
mitchelsellers merged 2 commits intodnnsoftware:developfrom
donker:smptset

Conversation

@donker
Copy link
Copy Markdown
Contributor

@donker donker commented Jun 22, 2022

Improves the edit boxes UI
Screenshot 2022-06-22 at 22 22 47

Copy link
Copy Markdown
Contributor

@mtrutledge mtrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @donker, wouldn't we need to do the same changes on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpAdminController.cs

that you did on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpHostController.cs

since the SMTP service on the javascript end checks if the user is an admin or a host and then calls a different end point?

@donker
Copy link
Copy Markdown
Contributor Author

donker commented Jun 22, 2022

Hey @donker, wouldn't we need to do the same changes on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpAdminController.cs

that you did on

/Dnn.PersonaBar.Extensions/Services/ServerSettingsSmtpHostController.cs

since the SMTP service on the javascript end checks if the user is an admin or a host and then calls a different end point?

Good catch. Thanks.

Copy link
Copy Markdown
Contributor

@mtrutledge mtrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @donker

@mitchelsellers mitchelsellers merged commit 56d41a7 into dnnsoftware:develop Jun 22, 2022
@david-poindexter
Copy link
Copy Markdown
Contributor

Good job @donker - thanks for the quick contribution on this!

@donker donker deleted the smptset branch July 24, 2022 08:27
valadas added a commit to valadas/Dnn.Platform that referenced this pull request Dec 18, 2022
Fixed an issue that prevented sending smtp test emails
Due to the UI changes in dnnsoftware#5152 the frontend now posts an obfuscated password unless the user is currently changing the password.
That scenario got handled correctly for UpdateSmtpSettings but the same logic needed to be implements in SendTestEmail for that button to work fine.
bdukes pushed a commit that referenced this pull request Dec 19, 2022
Fixed an issue that prevented sending smtp test emails
Due to the UI changes in #5152 the frontend now posts an obfuscated password unless the user is currently changing the password.
That scenario got handled correctly for UpdateSmtpSettings but the same logic needed to be implements in SendTestEmail for that button to work fine.
zyhfish pushed a commit to zyhfish/Dnn.Platform that referenced this pull request Dec 29, 2022
Fixed an issue that prevented sending smtp test emails
Due to the UI changes in dnnsoftware#5152 the frontend now posts an obfuscated password unless the user is currently changing the password.
That scenario got handled correctly for UpdateSmtpSettings but the same logic needed to be implements in SendTestEmail for that button to work fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants