Update dependencies, holding openai and ipython back#268
Merged
EliahKagan merged 1 commit intodmvassallo:mainfrom Dec 4, 2023
Merged
Update dependencies, holding openai and ipython back#268EliahKagan merged 1 commit intodmvassallo:mainfrom
EliahKagan merged 1 commit intodmvassallo:mainfrom
Conversation
This constrains openai<1 for now. Showing how to work with and wrap the old Python API is a central part of this project, so it's unclear what will be done with that moving forward. The options are to stay with <1 indefinitely, move up to 1, or support both conditionally (which should usually be avoided, but for this project it might be nice to show how to do so when needed). Note that embeddings_utils is not present in openai>=1. Less importantly, this also pins ipython back to ~8.12.3, which is actually a downgrade. This is to support Python 3.8. Before, we were installing an older version just on older Pythons, as we do with numpy and scipy. For ipython, the reason to give newer Pythons the newer version was that the convenient and popular way to autocomplete a full line, by pressing right-arrow, was broken, and the fix initially had not been backported. This is now fixed, due to the backporting of ipython/ipython#14080 to 8.12, which is in the 8.12.3 patch.
Collaborator
Author
|
Green at EliahKagan@531bdd8, merging. |
EliahKagan
added a commit
to EliahKagan/EmbeddingScratchwork
that referenced
this pull request
Dec 4, 2023
So Dependabot commands can be issued specific to updates to that package. Currently we are holding it back <1. See dmvassallo#268 (531bdd8).
EliahKagan
added a commit
that referenced
this pull request
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This constrains openai<1 for now. Showing how to work with and wrap the old Python API is a central part of this project, so it's unclear what will be done with that moving forward. The options are to stay with <1 indefinitely, move up to 1, or support both conditionally (which should usually be avoided, but for this project it might be nice to show how to do so when needed). Note that embeddings_utils is not present in openai>=1.
Less importantly, this also pins ipython back to ~8.12.3, which is actually a downgrade. This is to support Python 3.8. Before, we were installing an older version just on older Pythons, as we do with numpy and scipy. For ipython, the reason to give newer Pythons the newer version was that the convenient and popular way to autocomplete a full line, by pressing right-arrow, was broken, and the fix initially had not been backported. This is now fixed, due to the backporting of ipython/ipython#14080 to 8.12, which is in the 8.12.3 patch.
See my branch for test status. This should only be merged if all CI checks at the tip of that branch are green.
This supersedes many, and possibly all, currently open Dependabot PRs.