More coverage#1
Closed
dmoody256 wants to merge 437 commits into
Closed
Conversation
… wrongly included in git windows package
Fix m4.py and docbook tests on windows
Signed-off-by: Mats Wichmann <mats@linux.com>
Fix java install location for centos 7 to resolve failing Java/multi-step.py test
… which takes different arguments than the expected msvc
Fix Java/multi-step.py to avoid picking up cygwin or mingw's link.exe which takes different arguments than the expected msvc linker
Fix some problems found if no MS compiler at all
attempt fixing TestSCons.where_is() for win32
… but as discussion indicates breaks other tests. WIP
… only applied when the number of children in the current build doesn't match the number in the previous build as retrieved from the sconsign file.
…e and reference to issue SCons#2980
…er to understand.
…ailable now. (And seems actually a little faster)
There are still possible errors due to timestamp-MD5 + cachedir + changed implicit or regular dependencies (but the same # of such as the previous build). These are not yet handled as the fix being used for changed number of such breaks a number of tests. This fix doe reduce the number of possible issues.
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 70.84%
=========================================
Files ? 117
Lines ? 20340
Branches ? 0
=========================================
Hits ? 14410
Misses ? 5930
Partials ? 0 |
dmoody256
pushed a commit
that referenced
this pull request
May 1, 2020
changes to unit test to avoid hitting the filesystem
dmoody256
pushed a commit
that referenced
this pull request
May 1, 2020
This change adds support for scanning multiple entries in an action string in order to better support the following use cases: 1. A file is provided in an action string and should be taken as a dependency. For example, an action string "$PERL somefile.pl". 2. An action string actually has two actions separated by &&. For example, "cd <some_dir> && $ZIP <args>". Adding support for #1 actually allows us to fix the test IMPLICIT_COMMAND_DEPENDENCIES.py on Windows, which was previously treating a Python file as executable even on Windows. This was causing tests to repeatedly open the default handler of Python files, which if set to Visual Studio causes DDE hangs. This test is fixed because now we can have the action string specify python as the first command and still take an implicit dependency on the script, which is now the second command.
dmoody256
pushed a commit
that referenced
this pull request
Jan 3, 2021
The way runtest.py passes the list of fixture directories is racy because it sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting on Python to start the subprocess before that list is overwritten when spawning the next directory. At least on Windows, the environment is not copied in subprocess.run so runtest.py may overwrite the list of fixture directories with the list for test #2 while the subprocess module is still kicking off test #1. I was able to easily reproduce this by running the command: `python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py` a few times in a row. However, with this fix, that command repeatedly succeeds. To validate ths fix, I also ran that command with "--xml a.xml" and "--xml a.xml --nopipefiles" to validate that those other executors worked correctly.
bdbaddog
pushed a commit
that referenced
this pull request
Apr 13, 2021
Slight reorg of setting default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove this paragraph
Please have a look at our developer documentation before submitting your Pull Request.
http://scons.org/guidelines.html
Contributor Checklist:
master/src/CHANGES.txtdirectory (and read theREADME.txtin that directory)