Skip to content

More coverage#1

Closed
dmoody256 wants to merge 437 commits into
masterfrom
more_coverage
Closed

More coverage#1
dmoody256 wants to merge 437 commits into
masterfrom
more_coverage

Conversation

@dmoody256

Copy link
Copy Markdown
Owner

Remove this paragraph

Please have a look at our developer documentation before submitting your Pull Request.

http://scons.org/guidelines.html

Contributor Checklist:

  • I have created a new test or updated the unit tests to cover the new/changed functionality.
  • I have updated master/src/CHANGES.txt directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

bdbaddog and others added 30 commits November 2, 2018 21:12
Fix m4.py and docbook tests on windows
Signed-off-by: Mats Wichmann <mats@linux.com>
Fix java install location for centos 7 to resolve failing Java/multi-step.py test
… which takes different arguments than the expected msvc
Fix Java/multi-step.py to avoid picking up cygwin or mingw's link.exe which takes different arguments than the expected msvc linker
Fix some problems found if no MS compiler at all
attempt fixing TestSCons.where_is() for win32
… but as discussion indicates breaks other tests. WIP
… only applied when the number of children in the current build doesn't match the number in the previous build as retrieved from the sconsign file.
…ailable now. (And seems actually a little faster)
There are still possible errors due to timestamp-MD5 + cachedir + changed implicit or regular dependencies (but the same # of such as the previous build).
These are not yet handled as the fix being used for changed number of such breaks a number of tests.
This fix doe reduce the number of possible issues.
@codecov-io

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@15ec7da). Click here to learn what that means.
The diff coverage is 50.92%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   70.84%           
=========================================
  Files             ?      117           
  Lines             ?    20340           
  Branches          ?        0           
=========================================
  Hits              ?    14410           
  Misses            ?     5930           
  Partials          ?        0

@dmoody256 dmoody256 closed this Jan 15, 2019
dmoody256 pushed a commit that referenced this pull request May 1, 2020
changes to unit test to avoid hitting the filesystem
dmoody256 pushed a commit that referenced this pull request May 1, 2020
This change adds support for scanning multiple entries in an action string in
order to better support the following use cases:

1. A file is provided in an action string and should be taken as a dependency.
   For example, an action string "$PERL somefile.pl".
2. An action string actually has two actions separated by &&. For example,
   "cd <some_dir> && $ZIP <args>".

Adding support for #1 actually allows us to fix the test
IMPLICIT_COMMAND_DEPENDENCIES.py on Windows, which was previously treating a
Python file as executable even on Windows. This was causing tests to repeatedly
open the default handler of Python files, which if set to Visual Studio causes
DDE hangs. This test is fixed because now we can have the action string specify
python as the first command and still take an implicit dependency on the
script, which is now the second command.
dmoody256 pushed a commit that referenced this pull request Jan 3, 2021
The way runtest.py passes the list of fixture directories is racy because it
sets it in os.environ['FIXTURE_DIRS'] and then spawns the subprocess, counting
on Python to start the subprocess before that list is overwritten when spawning
the next directory. At least on Windows, the environment is not copied in
subprocess.run so runtest.py may overwrite the list of fixture directories
with the list for test #2 while the subprocess module is still kicking off
test #1. I was able to easily reproduce this by running the command:
`python runtest.py -j 2 test\MSVC\VSWHERE.py test\AS\ASPPFLAGS.py`
a few times in a row. However, with this fix, that command repeatedly succeeds.

To validate ths fix, I also ran that command with "--xml a.xml" and
"--xml a.xml --nopipefiles" to validate that those other executors worked
correctly.
bdbaddog pushed a commit that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants