fix: \\n should be changed to \n only when escapeSpecialCharacters is set#91
Merged
JoshuaKGoldberg merged 2 commits intodmnd:mainfrom Apr 10, 2024
Merged
fix: \\n should be changed to \n only when escapeSpecialCharacters is set#91JoshuaKGoldberg merged 2 commits intodmnd:mainfrom
JoshuaKGoldberg merged 2 commits intodmnd:mainfrom
Conversation
JoshuaKGoldberg
requested changes
Apr 9, 2024
Collaborator
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM! Could you add a test to dedent-tests.ts please?
Contributor
Author
Thanks! I have added a test. |
|
🎉 This is included in version v1.5.2 🎉 The release is available on: Cheers! 📦🚀 |
renovate bot
referenced
this pull request
in JoshuaKGoldberg/eslint-plugin-expect-type
Apr 13, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dedent](https://togithub.com/dmnd/dedent) | [`1.5.1` -> `1.5.2`](https://renovatebot.com/diffs/npm/dedent/1.5.1/1.5.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dmnd/dedent (dedent)</summary> ### [`v1.5.2`](https://togithub.com/dmnd/dedent/releases/tag/v1.5.2) [Compare Source](https://togithub.com/dmnd/dedent/compare/v1.5.1...v1.5.2) #### What's Changed - chore: remove files related to Flow by [@​yinm](https://togithub.com/yinm) in [https://github.com/dmnd/dedent/pull/77](https://togithub.com/dmnd/dedent/pull/77) - build: onboarded to create-typescript-app (mostly) by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/55](https://togithub.com/dmnd/dedent/pull/55) - chore: fix special characters escaping issue link in README by [@​auvred](https://togithub.com/auvred) in [https://github.com/dmnd/dedent/pull/82](https://togithub.com/dmnd/dedent/pull/82) - chore: replace last yarn references with pnpm by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/86](https://togithub.com/dmnd/dedent/pull/86) - docs: add explicit install command to README.md by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/84](https://togithub.com/dmnd/dedent/pull/84) - fix: switch babel-plugin-macros to a peer dependency (again) by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/89](https://togithub.com/dmnd/dedent/pull/89) - build(deps-dev): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dmnd/dedent/pull/87](https://togithub.com/dmnd/dedent/pull/87) - fix: \n should be changed to \n only when escapeSpecialCharacters is set by [@​fuenfundachtzig](https://togithub.com/fuenfundachtzig) in [https://github.com/dmnd/dedent/pull/91](https://togithub.com/dmnd/dedent/pull/91) #### New Contributors - [@​yinm](https://togithub.com/yinm) made their first contribution in [https://github.com/dmnd/dedent/pull/77](https://togithub.com/dmnd/dedent/pull/77) - [@​auvred](https://togithub.com/auvred) made their first contribution in [https://github.com/dmnd/dedent/pull/82](https://togithub.com/dmnd/dedent/pull/82) - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/dmnd/dedent/pull/87](https://togithub.com/dmnd/dedent/pull/87) - [@​fuenfundachtzig](https://togithub.com/fuenfundachtzig) made their first contribution in [https://github.com/dmnd/dedent/pull/91](https://togithub.com/dmnd/dedent/pull/91) **Full Changelog**: dmnd/dedent@v1.5.1...v1.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/JoshuaKGoldberg/eslint-plugin-expect-type). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
jcfranco
referenced
this pull request
in Esri/calcite-design-system
Apr 16, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dedent](https://togithub.com/dmnd/dedent) | [`1.5.1` -> `1.5.3`](https://renovatebot.com/diffs/npm/dedent/1.5.1/1.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dmnd/dedent (dedent)</summary> ### [`v1.5.3`](https://togithub.com/dmnd/dedent/releases/tag/v1.5.3) [Compare Source](https://togithub.com/dmnd/dedent/compare/v1.5.2...v1.5.3) #### What's Changed - fix: remove engines and provenance requirements by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/93](https://togithub.com/dmnd/dedent/pull/93) **Full Changelog**: dmnd/dedent@v1.5.2...v1.5.3 ### [`v1.5.2`](https://togithub.com/dmnd/dedent/releases/tag/v1.5.2) [Compare Source](https://togithub.com/dmnd/dedent/compare/v1.5.1...v1.5.2) #### What's Changed - chore: remove files related to Flow by [@​yinm](https://togithub.com/yinm) in [https://github.com/dmnd/dedent/pull/77](https://togithub.com/dmnd/dedent/pull/77) - build: onboarded to create-typescript-app (mostly) by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/55](https://togithub.com/dmnd/dedent/pull/55) - chore: fix special characters escaping issue link in README by [@​auvred](https://togithub.com/auvred) in [https://github.com/dmnd/dedent/pull/82](https://togithub.com/dmnd/dedent/pull/82) - chore: replace last yarn references with pnpm by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/86](https://togithub.com/dmnd/dedent/pull/86) - docs: add explicit install command to README.md by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/84](https://togithub.com/dmnd/dedent/pull/84) - fix: switch babel-plugin-macros to a peer dependency (again) by [@​JoshuaKGoldberg](https://togithub.com/JoshuaKGoldberg) in [https://github.com/dmnd/dedent/pull/89](https://togithub.com/dmnd/dedent/pull/89) - build(deps-dev): bump [@​babel/traverse](https://togithub.com/babel/traverse) from 7.22.8 to 7.23.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dmnd/dedent/pull/87](https://togithub.com/dmnd/dedent/pull/87) - fix: \n should be changed to \n only when escapeSpecialCharacters is set by [@​fuenfundachtzig](https://togithub.com/fuenfundachtzig) in [https://github.com/dmnd/dedent/pull/91](https://togithub.com/dmnd/dedent/pull/91) #### New Contributors - [@​yinm](https://togithub.com/yinm) made their first contribution in [https://github.com/dmnd/dedent/pull/77](https://togithub.com/dmnd/dedent/pull/77) - [@​auvred](https://togithub.com/auvred) made their first contribution in [https://github.com/dmnd/dedent/pull/82](https://togithub.com/dmnd/dedent/pull/82) - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/dmnd/dedent/pull/87](https://togithub.com/dmnd/dedent/pull/87) - [@​fuenfundachtzig](https://togithub.com/fuenfundachtzig) made their first contribution in [https://github.com/dmnd/dedent/pull/91](https://togithub.com/dmnd/dedent/pull/91) **Full Changelog**: dmnd/dedent@v1.5.1...v1.5.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaG9yZSIsImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a fix to the issue #90.
PR Checklist
status: accepting prs